from `htmlEscape` to `safeHTML` on attr. `title` - Githubissues

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity

Other

571 stars 263 forks source link

from `htmlEscape` to `safeHTML` on attr. `title` #339

Closed m4l4v1t4 closed 2 years ago

m4l4v1t4 commented 2 years ago

The attribute title of HTML elements cannot render HTML tags. Then, the correct is to use safeHTML rather then htmlEscape. This way we can use HTML tag on caption (featureImageCap) without rendering escaped HTML (like <cite>) on title figure tag attribute.

This PR...

Changes / fixes

-

Screenshots (if applicable)

(prefer animated gif)

Checklist

Ensure you have checked off the following before submitting your PR.

[x] tested locally with the latest release of Hugo. This requirement is a standard
[ ] added new dependencies
[ ] updated the [docs]() ⚠️

rootwork commented 2 years ago

Confirmed. Thanks for this fix @m4l4v1t4!