search

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
571 stars 263 forks source link

i18n for `Copy Link` term #346

Closed rdeprera closed 2 years ago

rdeprera commented 2 years ago

Making Copy Link term a i18n var

This PR...

Changes / fixes

-

Screenshots (if applicable)

(prefer animated gif)

Checklist

Ensure you have checked off the following before submitting your PR.

rootwork commented 2 years ago

@rdeprera As I read through these I think that this PR, #342 and #343 (edit: and #344 and #345) are all working together to do the same thing: Provide translatable strings for the code block actions.

If I'm correct, I think that's a good idea. Since they're all connected to each other, can you move the changes from those other two PRs into this PR and then and close the other two? I think these can all go in together.

Looking at your profile, I am guessing that your first language is not English. This is fine. I've tried to use wording here that will go easily through Google Translate. In the future, please use Google Translate yourself in order to provide more description in your PR. That will help us understand what we are reviewing. If the translations are not perfect, it's no big deal. Thank you!

chipzoller commented 2 years ago

@rdeprera please address outstanding comments and requests by maintainers.