Fix search index url - Githubissues

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity

Other

571 stars 263 forks source link

Fix search index url #348

Closed onweru closed 2 years ago

onweru commented 2 years ago

This PR fixes a regression that causes a // in search index JSON URLs in production.

Changes / fixes

Fixes page language lookup On Brave browser, the lang attribute on the HTML element somehow defaults to en, ignoring the value set here. This quirk, results in the wrong search index URL in non-english pages. Setting the language via a data attribute avoids this issue.
Change how search JSON URL is constructed
Fixes forEach loop

Screenshots (if applicable)

(prefer animated gif)

Checklist

Ensure you have checked off the following before submitting your PR.

[x] tested locally with the latest release of Hugo. This requirement is a standard
[ ] added new dependencies
[ ] updated the [docs]() ⚠️

rootwork commented 2 years ago

Thank you for this! I believe this also fixes #341