search

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
571 stars 263 forks source link

Add Japanese translation #355

Closed mkaraki closed 2 years ago

mkaraki commented 2 years ago

This PR...

Changes / fixes

Screenshots (if applicable)

image

Checklist

Ensure you have checked off the following before submitting your PR.

rootwork commented 2 years ago

@mkaraki

Not knowing Japanese, I can only assume these translations are accurate. Two items look untranslated; if you know the translations for these can you include them? (see review below)

Can you sign-off your code to satisfy the DCO check? You can do this by appending -s to your git commit. More details on this are in the check.

mkaraki commented 2 years ago

@rootwork In Japanese, almost all site use Copyright (c) year name. All right reserved in footer of page. So I didn't made translated it. (I think Chinese translation is same)

I did -s --amend and I think now it's pass DCO check.

KaitaKoinuma commented 2 years ago

I'm Japanese, these translations seem correct to me! I'm looking forward to merging this PR.

rootwork commented 2 years ago

@mkaraki I'm not sure why the git -s --amend push didn't satisfy the DCO check -- maybe you can't amend a signoff? -- but in any case given that you were obviously trying to thus signoff the DCO I'm going to manually approve it and merge. Thanks for your contribution!