search

chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
577 stars 262 forks source link

Feature/lastmod #449

Open orlea opened 12 months ago

orlea commented 12 months ago

Pull Request type

Please check the type of change your PR introduces:

Current state

Once an article has been updated, it may be revised later. I set up lastmod but it was not reflected and I could not find it in previous issues, so I added it.

Proposed changes

Screenshots, if applicable

Checklist

Signed-off-by: aries aries@asterism.xyz

chipzoller commented 12 months ago

Can you show how this looks, please? Also, can you please sign off on your commits?

orlea commented 12 months ago

I git rebase --signoff and force push. Is this OK? Also, it looks as follows How it looks on the top page image How it looks on the article itself image

chipzoller commented 12 months ago

Can we stack them vertically rather than horizontally? I think that'd be easier to read.

orlea commented 12 months ago

Is it like this? It's just a line break and doesn't look good. I would like to make it more visible but I don't know because I am not familiar with the front end. 😔

Points that I think are not good

Note: This line break correction has not yet been commit. image

chipzoller commented 12 months ago

Ok, was worth a try. What do you think, @onweru ?

onweru commented 11 months ago

Ok, was worth a try. What do you think, @onweru ?

@chipzoller, just seeing this.

Horizontal would be probably easier, due to spacing/line-height constraints. #450, looks like duplicate of this. It's stacked horizontally but it also lacks the clarity present here ... i.e it's not obvious that the second date is the lastmod.