chipzoller / hugo-clarity

A theme for Hugo based on VMware Clarity
Other
577 stars 262 forks source link

Fix icons/src property so that it does not 404 #459

Closed digitalbricklayer closed 6 months ago

digitalbricklayer commented 7 months ago

Fix for the icons in site.webmanifest pointing to the wrong location. The src property points to the root of the site instead of the icons directory.

Pull Request type

Please check the type of change your PR introduces:

Current state

Closes #458

Proposed changes

Changes the icon src to be relative to the icons folder. According to the site.webmanifest spec, if you specify a relative link, it assumes that the link is relative to the location of the site.webmanifest file itself.

Screenshots, if applicable

Checklist

I am adhering to the Developer Certificate of Origin.

chipzoller commented 7 months ago

Please sign off on your commits.

digitalbricklayer commented 7 months ago

I am adhering to the Developer Certificate of Origin.

chipzoller commented 7 months ago

Your commits must be signed.

digitalbricklayer commented 7 months ago

Can confirm change is now signed-off.