search

chiradeep / go-nitro

A Golang client to the Citrix ADC API
Apache License 2.0
18 stars 21 forks source link

Changes for adding the functionality for the nsacls library #4

Closed sanket4373 closed 7 years ago

sanket4373 commented 7 years ago
sanket4373 commented 7 years ago

@chiradeep: updated the unit test.

sanket4373 commented 7 years ago

@chiradeep: I hope that unit test is what you were expecting. Kindly let me know if you need any further changes on this one.

chiradeep commented 7 years ago

Didn't build. I made some changes and pushed it to https://github.com/chiradeep/go-nitro/tree/sanket4373-feature/nsacls . Please check it out

sanket4373 commented 7 years ago

What is the error that you are getting?

chiradeep commented 7 years ago

github.com/chiradeep/go-nitro/netscaler

netscaler/config_test.go:27:2: cannot find package "github.com/go-nitro/config/ns" in any of: /usr/local/go/src/github.com/go-nitro/config/ns (from $GOROOT) /Users/chiradeep/source/go/src/github.com/go-nitro/config/ns (from $GOPATH)

sanket4373 commented 7 years ago

@chiradeep: I was able to build the SDK using your code changes. It is because you were trying to access the package from this location (the library is yet to be added your repo) github.com/chiradeep/go-nitro/config/ns, the link to your changes: https://github.com/chiradeep/go-nitro/commit/42a5d8877682a75ef562bbd4dc50f1fcc7b80b40#diff-1168d2b2b293dbb9b5643b6e68eaa1f9R27 .

For testing you will need to replace it with this path: github.com/go-nitro/config/ns. That should take care of that error.

sanket4373 commented 7 years ago

@chiradeep: pushed new changes for the unit tests as per the changes on your branch from here: https://github.com/chiradeep/go-nitro/tree/sanket4373-feature/nsacls

chiradeep commented 7 years ago

Superseded by PR #5