search

chirag04 / react-native-in-app-utils

A react-native wrapper for handling in-app payments
MIT License
890 stars 185 forks source link

Add manual purchase finish #121

Closed lunarraid closed 6 years ago

lazyhoneyant commented 6 years ago

@lunarraid Why do you close this PR? I use your PR well. Is there any problem on this PR?

lunarraid commented 6 years ago

This PR was made in error. I meant to pull the change into the master branch of my fork only, as this change breaks compatibility with the main repo.

lazyhoneyant commented 6 years ago

@lunarraid I understand. I've used this PR to my fork repo. Thanks for sharing your useful code.

Jacse commented 6 years ago

@lunarraid this is extremely useful and necessary for the library. Do you think you could be convinced to merge your functionality into the lib?

lunarraid commented 6 years ago

I have no problem with re-opening this if the maintainer is cool with the breaking changes.

chirag04 commented 6 years ago

I'm fine with making a breaking change. Refer the thread here: https://github.com/chirag04/react-native-in-app-utils/issues/124#issue-262259337

lunarraid commented 6 years ago

https://github.com/chirag04/react-native-in-app-utils/pull/135 has been opened.