Fix for #16 (loadProducts does not return any error when there is no network)

chirag04 / react-native-in-app-utils

A react-native wrapper for handling in-app payments

MIT License

890 stars 185 forks source link

Closed wasedaigo closed 7 years ago

wasedaigo commented 7 years ago

In case of no network, loadProducts should return an error instead of returning nothing.

chirag04 commented 7 years ago

looks good. @agolovenko can you confirm this works for you?

BodySplash commented 7 years ago

Hi, I was about to do the very same PR. Any updates on when it would be merged ?

chirag04 commented 7 years ago

i'm worried that will fail when restore purchase request fails.

BodySplash commented 7 years ago

What do you fear exactly ?

I just noticed also that this PR does not remove the request from _callbacks.

chirag04 commented 7 years ago

ok. sorry i got confused. restore purchases is not using SKRequest. so this is fine.