search

chirag04 / react-native-mail

A wrapper on top of MFMailComposeViewController from iOS and Mail Intent on android
MIT License
445 stars 249 forks source link

5.0.0 crash in android #151

Closed jihokim2 closed 4 years ago

jihokim2 commented 4 years ago

I can not build in android.

Log is like this.

/react-native-mail/android/src/main/java/com/chirag/RNMail/RNMailModule.java:90: error: cannot find symbol ArrayList uris = new ArrayList(); ^ symbol: class ArrayList location: class RNMailModule /react-native-mail/android/src/main/java/com/chirag/RNMail/RNMailModule.java:90: error: cannot find symbol ArrayList uris = new ArrayList(); ^ symbol: class ArrayList location: class RNMailModule Note: /node_modules/react-native-mail/android/src/main/java/com/chirag/RNMail/RNMailModule.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. 2 errors

Please, fix this.

Relax594 commented 4 years ago

+1

chirag04 commented 4 years ago

@brightsider looks like an import issue. can somebody send a PR real quick?

Relax594 commented 4 years ago

there you go https://github.com/chirag04/react-native-mail/pull/152

chirag04 commented 4 years ago

awesome! thank you. published 5.0.1 with the fix,.