chiralcentre / pe

0 stars 0 forks source link

menu command supports adding items with costs and sales decimal figures with more than 2 decimal places #4

Open chiralcentre opened 6 months ago

chiralcentre commented 6 months ago

As shown here, I can add a menu item cake with cost 8.9999 and sales 9.9999. Some warning should be shown for this addition, as prices normally have a maximum of 2 decimal places.

image.png

soc-pe-bot commented 6 months ago

Team's Response

This is intended. For situations where customers can only buy in sets of 2 cupcakes but users i.e. the business owners want to track the cost and sales of each individual cupcake, sales can often exceed 2 decimal places. When considering the cost of each cupcake based on the proportion of ingredients used, for example, 70g of flour of 1kg packet with price of 9.50, the cost of flour used would be $0.665. Hence, for accurate calculation of profits, it is possible that prices exceed 2 decimal places and we do not see the need to limit to 2 decimal places. Moreover, this app is designed mainly for business owners and not for display for customers. It is true that when displaying the prices to customers, we would limit it to 2 decimal places but that is not the intended use of Strack.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that prices can exceed 2 decimal places, but it is not necessarily the norm for prices to exceed 2 decimal places. As mentioned in the original issue, I believe some warning should be shown for such cases to inform the user, as it is possible that a typo was made on the users' end (e.g typing an extra 9 at the end) and the user may want to correct that.