chirpstack / chirpstack-concentratord

Concentrator HAL daemon for LoRa gateways.
https://www.chirpstack.io/
MIT License
76 stars 56 forks source link

Update concentratord runtime stats_interval with the configured gateway stats_interval from a GatewayConfiguration ChirpStack message #181

Closed nicolas-juteau closed 2 months ago

nicolas-juteau commented 2 months ago

Summary

ChirpStack already relays the configured gateway stats_interval in a GatewayConfiguration message sent to concentratord. However, concentratord just seem to silently ignore the stats_interval and simply proceeds to channel reconfiguration, if required.

What is the use-case?

Implementation description

Looks like updating config.concentratord.stats_interval with the received new_config.stats_interval in function update_configuration of files src/handler/config.rs would do the trick.

I don't know why it is not already done in the first place.

Can you implement this by yourself and make a pull request?

Yes. However, my rust knowledge is rusty (aka non-existent) and it would without a doubt be cleaner if done by knowledged rust developer

brocaar commented 2 months ago

Thanks for reporting, the above commit fixes this.