search

chirpstack / chirpstack-docker

Setup ChirpStack using Docker Compose
https://www.chirpstack.io/
MIT License
275 stars 316 forks source link

MQTT authentication for gateway #31

Closed Diss31 closed 4 years ago

Diss31 commented 4 years ago

We integrated the Mosquitto-Go-Auth plugin from iegomez's work (here is their GitHub: https://github.com/iegomez/mosquitto-go-auth) to allow the MQTT authentication for gateways. This feature adds a new layer of security and the possibility to manage authorizations.

This pull request comes with two others, on ChirpStack API and ChirpStack Application Server repositories.

bconway commented 4 years ago

I worry that this specialized use case may make the docker-compose skeleton unapproachable for some.

Diss31 commented 4 years ago

@blocknonip I agree with you, there are probably more elegant and maintainable ways to include the Mosquitto plugin than this one. One way could be to use the standard Mosquitto image and provide a script to install the plugin on it. Another is to include the iegomez's work inside of the ChirpStack project, so it will keep update.

brocaar commented 4 years ago

Also thanks for this work. However, I agree with @blocknonip that this is a specific use-case. My comment on #30 does also apply to this pull-request.

The goal of this repository to show all components working with just a docker-compose up. It is not a production ready solution, but could be used as an example to setup a production environment.

Please do share your work with the community (https://forum.chirpstack.io). I do think that this is useful, but I don't think this should be included as the default because of reasons I also mentioned in #30.

Diss31 commented 4 years ago

@brocaar We agree with your opinion, as in #30. We also close the pull requests linked with this one.