brd value change to uint32

chirpstack / chirpstack-gateway-bridge

ChirpStack Gateway Bridge abstracts Packet Forwarder protocols into Protobuf or JSON over MQTT.

https://www.chirpstack.io

MIT License

422 stars 270 forks source link

Closed gillespilloudkerlink closed 5 years ago

gillespilloudkerlink commented 5 years ago

use uint32 instead of uint8 for Board values.

gillespilloudkerlink commented 5 years ago

in reference of #104 issue

brocaar commented 5 years ago

Thank @gillespilloudwyres

You mentioned that the Protobuf Board field is of type uint32. In that case you don't have to cast the fields (e.g. Brd: uint32(frame.TxInfo.Board) could simply be Brd: frame.TxInfo.Board).
Could you install a Go plugin for your editor? That will (usually) automatically format the source-code :slightly_smiling_face: E.g. for VSCode there is: https://github.com/Microsoft/vscode-go. This is not a big issue, but it helps to keep the code formatted.

brocaar commented 5 years ago

I've merged your pull-request with one change (in the legacy code, it had to be casted to an int): https://github.com/brocaar/lora-gateway-bridge/commit/82adc02bd11a64d48a5459f01ae429e1fcc2fdb3.

brocaar commented 5 years ago

Will release this as v2.7.1 and will also create packages for the Kerlink gateways: https://www.loraserver.io/lora-gateway-bridge/gateway/kerlink/