Closed comet-GmbH closed 5 years ago
For accessing config.C package config needs to be imported. This ends up in import cycle because config imports semtech. Don't know how to prevent this at the moment.
Hm, it's unfortunate. I tested before and had no issues but maybe in a different package.
Found a solution. It looks much better now.
:+1: this has been merged as https://github.com/brocaar/lora-gateway-bridge/commit/d844441757cb057a4a5b689c2650c34fa4ba10b1.
I do agree that passing the global config might be better, however changing this now while the v3 branch already contains a refactor of this does make it more complex merging your work also into that branch (which I will do shortly). So I have reverted your PR until the point where you pass the setting instead of the config object.
The Semtech packet-forwarder does not fill up the time and tmms fields if the gateway has no GPS.
Does nobody want to get a receive-time ?
This patch is for setting the time from system-time if it is empty. A configuration flag is included to control behavior. Should work on V2 + V3.
Something wrong ?