search

chirpstack / chirpstack-gateway-bridge

ChirpStack Gateway Bridge abstracts Packet Forwarder protocols into Protobuf or JSON over MQTT.
https://www.chirpstack.io
MIT License
415 stars 269 forks source link

TerminateOnConnect not working with MqTT Autoreconnect #159

Closed schmo90 closed 3 years ago

schmo90 commented 4 years ago

Is this a bug or a feature request?

Mqtt is not correctly reconnecting again after lost of internet connection

What did you expect?

Application is closing

What happened?

Application is running in a endless loop

What version are your using?

3.6

How can your issue be reproduced?

tc qdisc add dev 3g-GPRS root netem loss 100% 100%

Modified Source Code

in backend.go func NewBackend(conf config.Config) (*Backend, error) { . . . b.clientOpts.SetAutoReconnect(false) . .

backend.go

func (b *Backend) onConnectionLost(c paho.Client, err error) { mqttDisconnectCounter().Inc() log.WithError(err).Error("mqtt: connection error") if b.terminateOnConnectError { log.Fatal(err) }

log.WithError(err).Error("integration/mqtt: connection error")
time.Sleep(time.Second * 2)

}

brocaar commented 4 years ago

Thanks. Instead of providing source modifications in an issue, would you mind creating a pull-request?

paolofrs commented 3 years ago

Hi, has this bug been fixed? I have a Dragino LPS8 Gateway at a rural location with bad internet coverage and I have to manually restart the gateway every time internet connection gets lost because the app do not reconnect to the MQTT broker.

I am using version 3.8.0 of gateway server .ipk download here. App and broker use MQTT over TLS (I don't know if this can make any difference).

paolofrs commented 3 years ago

I've found this discussion and this reply.

Is this fix supposed to fix our reconnection problem as well (avoiding the endless loop)?

If so, it should be enough for me to update the gateway on the LPS8 to the latest release (i.e. 3.9.2-r1)?

gbird3 commented 3 years ago

From my testing, the terminateOnConnect seems to only work when the gateway-bridge is starting up. If the mosquitto connection dies while the gateway-bridge is running, it is not terminating it. Is this the way it is designed?

For my use case, it would be really helpful to have it terminate after startup. I have been running into issues where it seems like the mqtt connection is dying and the gateway-bridge can't reconnect. In this case, as soon as I restart the gateway-bridge everything starts working again.

brocaar commented 3 years ago

I have just merged a fix for this.