search

chirpstack / chirpstack-gateway-bridge

ChirpStack Gateway Bridge abstracts Packet Forwarder protocols into Protobuf or JSON over MQTT.
https://www.chirpstack.io
MIT License
415 stars 269 forks source link

Add support for port 80 in basics station #189

Closed gbird3 closed 2 years ago

gbird3 commented 3 years ago

PR for #188

The r.host drops the port information if it is port 80. This makes it so the gateways get the wrong router_config and can't connect properly.

Add a check for if the port doesn't exist, and if it doesn't default to port 80.

brocaar commented 3 years ago

Sorry for the late response. I have not tested this, but is this a bug at the ChirpStack Gateway Bridge side, or Basics Station?

image

( https://datatracker.ietf.org/doc/html/rfc6455#section-3 )

The Basics Station should use port 80 for ws:// and port 443 for wss://. Therefore this change should not be needed?

brocaar commented 3 years ago

Added to the above, would this work with IPv6, where an IP can contain colons and if the port is present, the IP and PORT are also separated by colons?