search

chirpstack / chirpstack-gateway-bridge

ChirpStack Gateway Bridge abstracts Packet Forwarder protocols into Protobuf or JSON over MQTT.
https://www.chirpstack.io
MIT License
425 stars 273 forks source link

Add CA file option for TLS connection #42

Closed minggi closed 7 years ago

siscia commented 7 years ago

:tada: :tada: :tada: :tada: :tada: :tada:

Congrats for your pull request :)

I believe the code it is very reasonable.

Let's wait for feedback from brocaar and we will move from there :)

brocaar commented 7 years ago

Thanks! I have added a few comments (just a few consistency related comments). Would you be able make these changes? Then I think it is good to merge :-)

minggi commented 7 years ago

@brocaar : Changes are done... and it works on my gateway. If this is ok, I will write a short installation manual for the lorixOne LorixOne Gateway.

siscia commented 7 years ago

OT @minggi , do you mind to write me an email, I am quite interested in those little gateways that you linked.

siscia commented 7 years ago

@brocaar , do you want me to add this change to the other loraserver and the lora-app-server too?

brocaar commented 7 years ago

If you would like to do so, that would be great!

nickumbe commented 7 years ago

This is working on my Conduit Gateways. Thank you! It would be great if lora-gateway-bridge could support client certificate authentication with MQTT as well.

siscia commented 7 years ago

@nickumbe , it doesn't look too difficult, why you don't try to submit a pull request?

Look at the previous thread about this issues: https://github.com/brocaar/lora-gateway-bridge/issues/37

You see how minggi was supported?

If you are interested in the feature the simplest thing you can do is to implement it yourself, ask feedback, fix whatever need to be fixed and finally get it merged.

Bonus point, after the first PR is accepted it is simpler to implement it in other parts of the architecture: https://github.com/brocaar/loraserver/pull/190