chiru-labs / ERC721A

https://ERC721A.org
MIT License
2.5k stars 839 forks source link

nfts not showing on opensea testnet rinkeby erc721@4.1.0 #350

Open softmuneeb opened 2 years ago

softmuneeb commented 2 years ago

opensea https://testnets.opensea.io/assets/rinkeby/0x2301334d923434Ff569ba4fD7FC19C35758086bE/1

rinkeby solidity code https://rinkeby.etherscan.io/address/0x2301334d923434ff569ba4fd7fc19c35758086be#code

nfts were showing in version 3.3.0 erc721a but not on erc721a 4.1.0

Vectorized commented 2 years ago

Looks like it’s an issue with OpenSea’s Transfer event listener. Did some tests recently and seems like they are sometimes unable to detect the first token minted.

Try minting more tokens or transferring the first token after minting.

Don’t worry too much about it, there have been projects published on mainnet using version 4.1.0.

softmuneeb commented 2 years ago

okay Thanks I got it. Thanks for explanation. You are genius.

softmuneeb commented 2 years ago

Issue not fixed

halversonmd commented 2 years ago

I had this same issue. Please see my solution here.

intenex commented 2 years ago

yeah - this is a supportsInterface issue; see the migration notes here on how to fix it: https://chiru-labs.github.io/ERC721A/#/migration?id=supportsinterface

Specifically, update your supportsInterface to be:

function supportsInterface(
    bytes4 interfaceId
) public view virtual override(ERC721A, ERC2981) returns (bool) {
    // Supports the following `interfaceId`s:
    // - IERC165: 0x01ffc9a7
    // - IERC721: 0x80ac58cd
    // - IERC721Metadata: 0x5b5e139f
    // - IERC2981: 0x2a55205a
    return 
        ERC721A.supportsInterface(interfaceId) || 
        ERC2981.supportsInterface(interfaceId);
}
Xuantho78 commented 1 year ago

![Uploading 8B07BEE7-FF96-4947-97FD-ECE9586C073B.jpeg…]()

Xuantho78 commented 1 year ago

Ngtho301178@gmail.com