Change startTokenId from 0 to 1.

chiru-labs / ERC721A

https://ERC721A.org

MIT License

2.51k stars 842 forks source link

Change startTokenId from 0 to 1. #413

Closed SahalAmeen closed 2 years ago

SahalAmeen commented 2 years ago

You have to understand. Nobody, and I mean, Nobody starts their tokenIDs from 0. All the smart contracts I coded required me to override the function. Each. and. every. time.

Please just make it start from 1. Like, 90% of the projects out there start with tokenID 1.

Vectorized commented 2 years ago

This is a breaking change.

We deliberately set the default to 0 so that devs can value-add for their non-programmer clients by changing it to 1.

Won’t merge.

Sorry for the inconvenience. Thank you for your understanding.