search

chiru-labs / ERC721A

https://ERC721A.org
MIT License
2.51k stars 843 forks source link

safeTransferFrom, approve, transferFrom external payable? #424

Open vakkuda opened 2 years ago

vakkuda commented 2 years ago

Are they supposed to be external payable? Imported then flattened in Remix 9/17/22 wasn't previous versions external payable

Vectorized commented 2 years ago

I think you need to right-click + delete the deps folder for the files to be redownloaded.

tomazmm commented 2 years ago

Since these functions are payable, they are not compatible with function signatures that OpenSea wants for their new Creator Fees system.

https://github.com/ProjectOpenSea/operator-filter-registry

Edit: Ignore my comment. It was a product of me being tired and stressed.

cygaar commented 2 years ago

Payable is unrelated to the new OpenSea policies. If you're talking about their specific filtering library, ERC721A still works. You just need to add the modifier to your transfer functions.

tomazmm commented 2 years ago

That's also what I thought. For some reason opensea thinks, I did not include Creator Fees functions.

Vectorized commented 2 years ago

@tomazmm If you want an optimized example using ERC721A, may I interest you in https://github.com/Vectorized/closedsea ;)

tomazmm commented 2 years ago

Oh cool. Will definitly look into it. I love your work and contribution. Much respect :blush: