Truncate long filenames to prevent error on Windows again

chirun-ncl / chirun

A Python package providing the command line interface for building flexible and accessible content with Chirun.

https://chirun.org.uk/

Other

29 stars 4 forks source link

Truncate long filenames to prevent error on Windows again #201

Closed prowlett closed 9 months ago

prowlett commented 9 months ago

To resolve issue #51 George made the generated filenames be based on truncated versions of the page titles. The issue was that I was building a course that @Alex-Corner couldn't pull via GitHub to his Windows machine because it couldn't cope with the long paths. At some point recently, chirun has started making longer filenames and now Alex can't pull our GitHub repo again. Can you arrange for chirun to return to shorter filenames?

prowlett commented 9 months ago

Just as a for example, we're getting filenames like

build/background_information/problemsolving_advice_and_what_to_do_if_you_get_stuck/problemsolving_advice_and_what_to_do_if_you_get_stuck.pdf
build/background_information/semester_1_week_1__what_is_recreational_mathematics/what_is_recreational_mathematics_and_when_did_it_arise/what_is_recreational_mathematics_and_when_did_it_arise.pdf

that last year were like

build/background_informati/problemsolving_advic/problemsolving_advic.pdf
build/background_informati/semester_1_week_1__w/what_is_recreational/what_is_recreational.pdf

christianp commented 9 months ago

Sorry about this! I didn't write down a justification for why I stopped truncating filenames, and I must have forgotten about the original issue; because George didn't tag it in the commit, I didn't see it when looking through the commit history.