search

chirun-ncl / chirun

A Python package providing the command line interface for building flexible and accessible content with Chirun.
https://chirun.org.uk/
Other
30 stars 4 forks source link

Test beamer compilation #243

Closed Lycanic closed 6 months ago

Lycanic commented 7 months ago

Test that images are put in correctly, and not as a snapshot of the entire slide as per #59

Uses the same diagram as in pdf2svg

christianp commented 7 months ago

Could you add a test for a PNG graphic, since the original issue said they behaved differently?

Lycanic commented 6 months ago

@christianp Do you want the PNG to have the same width-based test? It was presented as an example of a format which did not cause the error, so I'm not entirely sure what to test for with it.

Lycanic commented 6 months ago

@christianp I've updated the tests for this as we discussed! I would like you to test thest tests on your computer to ensure there's no difference in the way the pdf viewBox is encoded (particularly, I'm concerned that the decimal places could vary between operating systems).

christianp commented 6 months ago

Looks like it works OK on my linux laptop!