chishanw / pe

0 stars 0 forks source link

Incorrect parsing of yes/no after card has been flipped #1

Open chishanw opened 4 years ago

chishanw commented 4 years ago

Steps to reproduce:

  1. play 1 (use the sample 1st deck)
  2. flip
  3. yes no (or typing any other command starting with "yes" will still get parsed as "yes")
  4. App responds telling you that you got the card right. App should instead parse to make sure that the command is exactly "yes", not as long as the command starts with the word "yes"

A similar problem is encountered with the "no" command - as long as the user input begins with "no", it gets parsed as the "no" command.

nus-pe-bot commented 4 years ago

Team's Response

Hello thank you for your report!

This was actually an intended design which our reason is stated below

It should be explanatory that we only take the first word as the command word.

Downgraded to very low as it does not affect usage at all.

Can be considered a duplicate of issue #1867 although commands are different.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Reasons given by team was a. User does not have to re-type command if he/she accidentally makes a typo.

Thank you for your response, and I'm sorry that I still feel this should be a valid bug!


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Disagree because it is not some minor bug that does not affect usage. It does affect the very core of your user's actions - the commands through which they interact with the app. If the command usage is not precise, it affects the user because the user will expect that only the exact command usage written in the User Guide will be accepted. It caused much confusion for me when I realised I could add anything after the first command word and it would still work.