search

chishanw / pe

0 stars 0 forks source link

Incorrect parsing and thus incorrect error message #5

Open chishanw opened 4 years ago

chishanw commented 4 years ago

Parsing is not done strictly enough. I typed in the command flip this into the command box. An error pops up as expected, but it is the wrong error.

Expected: An error telling the user it is an unknown command. Actual: The app parses it and mistakenly recognises it as a flip command.

image.png

nus-pe-bot commented 4 years ago

Team's Response

Hello thank you for your report!

Expected: An error telling the user it is an unknown command. Actual: The app parses it and mistakenly recognises it as a flip command.

We actually gave this error message so that the user will know that they have used a valid command, except in the wrong context. If we were to say that it is an unknown command, it might lead the user to think that that command does not exist and might confuse the user instead!

Downgraded to very low as it does not affect usage at all. If the user read the user guide, the user should be able to figure out easily that the command is not for this context.

If you mean that the parser is not catching the invalid second word in the command, then it is a duplicate of issue #1867

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your reponse, I understand now. In that case, I believe this would be a duplicate of issue #1867, about the unprecise parsing of commands (I'm not sure which is issue #1867 because I can't see the issue number, but yeah it's about the parsing extra words after the first command word). Hence, due to similar reasons for rejecting that issue, I would reject this one as well. Sorry!

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Disagree because it is not some minor bug that does not affect usage. It does affect the very core of your user’s actions - the commands through which they interact with the app. If the command usage is not precise, it affects the user because the user will expect that only the exact command usage written in the User Guide will be accepted. It caused much confusion for me when I realised I could add anything after the first command word and it would still work.