search

chishanw / pe

0 stars 0 forks source link

Incorrect parsing of edit command when in the play view #6

Open chishanw opened 4 years ago

chishanw commented 4 years ago

Steps to reproduce:

  1. play 1
  2. edit 1

Expected: An error telling the user they cannot edit a card in the play view, or that the command is unknown. Actual: An error telling me the edit command format is wrong. The app should prioritise telling the user that the command is unknown or the editing cannot be done in play view.

image.png

nus-pe-bot commented 4 years ago

Team's Response

Hello, thank you for your report.

Please note that the syntax of your edit command is invalid.

Expected: An error telling the user they cannot edit a card in the play view, or that the command is unknown. Actual: An error telling me the edit command format is wrong. The app should prioritise telling the user that the command is unknown or the editing cannot be done in play view.

The reason why we did not have a message saying that the command is unknown is because we would like the user to know that they have entered a valid command word, but in the wrong format. If we were to tell the user it is unknown, it might confuse the user and the user might think that the command word doesnt exist at all.

Also, if the user entered a valid edit command, then our product will throw an error saying that the command cannot be done in play view. Because the user typed in the incorrect format, we first warned the user that the command they are trying to execute is in the wrong format. Then, if they have the correct format but wrong context, we will then tell them the error is wrong.

This is a result of the design of our product and we will take this suggestion into our design in future update

Rejected because it is a suggestion and not a bug due to our product design.

Also, downgraded to low as it only causes a minor inconvenience to the user and does not affect product operations/usage

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]