search

chitochi / flutter_inset_shadow

This package extends BoxShadow and BoxDecoration to support the inset property. [maintainer=@chitochi]
https://pub.dev/packages/flutter_inset_shadow
BSD 3-Clause "New" or "Revised" License
19 stars 8 forks source link

Fix for Issue #7 #8

Closed vasilich6107 closed 1 year ago

vasilich6107 commented 1 year ago

Hi @johynpapin could you check the PR

ghost commented 1 year ago

Hi! Thank you very much for this PR! :pray:

I will check it as soon as I can!

ghost commented 1 year ago

Hello !

Sorry for the wait, I was traveling. Thanks a lot for this contribution, I did some tests and everything seems to work on my side!

To be very honest I don't really remember why I chose srcIn. I will try to understand this code better later.

I will publish a new version! :tada:

vasilich6107 commented 1 year ago

Hi @johynpapin Please be aware that there is an issue for impeller https://github.com/flutter/flutter/issues/127232

It is considered as a bug But maybe makes sense to bump package to v2 to omit auto updates

ghost commented 1 year ago

Thank you so much for opening this issue @vasilich6107! :pray:

The bug is present on the current version too, right? (#4)

vasilich6107 commented 1 year ago

@johynpapin it seems that there is no bug for srcIn case. Only for src

ghost commented 1 year ago

OK, I will follow your advice then!