search

chiwanpark / flume-ng-redis

Redis extension for Flume NG
26 stars 20 forks source link

Proper handling of Redis connection issues #15

Closed theintz closed 9 years ago

theintz commented 9 years ago

When the redis connection breaks in the Redis{List, Publish}DrivenSink, Flume cannot find out about it, because the exception is not propagated up. This is however very useful for usage for example with the FailoverSinkProcessor, which would switch to a backup redis sink in those cases.

This PR fixes the classes so that the failure is reported to Flume (through rethrowing the exception) and also resets the connection, so that upon the next invocation it will automatically try to reconnect.

chiwanpark commented 9 years ago

Hi, Thank you for contribution. I'll check the changes and merge this soon.

chiwanpark commented 9 years ago

Thanks! I merged this PR into master branch. Because you used your master branch to contribute, you should pull my master branch using force-pull.