search

chiwanpark / flume-ng-redis

Redis extension for Flume NG
26 stars 20 forks source link

Make RawHandler handle binaries instead of Strings #20

Closed philipphoffmann closed 7 years ago

philipphoffmann commented 7 years ago

Before this commit, RawHandler was handling incoming/outgoing binaries as UTF-8 Strings. This breaks binary messages which are indeed binary (e.g. Thrift binaries).

This commit makes the RawHandler handle incoming/outgoing binaries as raw binaries. Note that this change still allows to pass along UTF-8 encoded messages without any changes.

philipphoffmann commented 7 years ago

For reference: #19

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 74.074% when pulling 1e940a664b4ba1c4b6532825f00b29b95cf476db on philipphoffmann:binary-raw-handler into 4d18de531e0c790a37c26b3e102a3357bc7912ef on chiwanpark:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 74.074% when pulling 1e940a664b4ba1c4b6532825f00b29b95cf476db on philipphoffmann:binary-raw-handler into 4d18de531e0c790a37c26b3e102a3357bc7912ef on chiwanpark:master.

philipphoffmann commented 7 years ago

hm, not sure what broke here, i only tested with oracle jre 8

philipphoffmann commented 7 years ago

@chiwanpark what do you think?

chiwanpark commented 7 years ago

Hello @philipphoffmann, thanks for your pull request. I've tested your changes in various environments. Your code is merged to master.

Thanks again for your valuable contribution. 👍

philipphoffmann commented 7 years ago

👍 thx