search

chiwanpark / flume-ng-redis

Redis extension for Flume NG
26 stars 20 forks source link

Added support for authentication and database number selection. #8

Closed faelenor closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.19%) to 83.87% when pulling 5ff87074f1ef15162bbaa5099e84901b5434f89b on faelenor:master into bad4bd23e1b92c5f6b13186831a4046c2a696693 on chiwanpark:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.19%) to 83.87% when pulling 5ff87074f1ef15162bbaa5099e84901b5434f89b on faelenor:master into bad4bd23e1b92c5f6b13186831a4046c2a696693 on chiwanpark:master.

chiwanpark commented 9 years ago

Thanks for your great work! I had some just minor remarks.

faelenor commented 9 years ago

I fixed the indentation. I realized that I only modified the source and not the sink (I only need the source). The same code could probably be copied in the sink if the feature is eventually needed by someone.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.19%) to 83.87% when pulling c667b1360fcc296941815b1add7e6050357c1513 on faelenor:master into bad4bd23e1b92c5f6b13186831a4046c2a696693 on chiwanpark:master.

chiwanpark commented 9 years ago

Great! Thanks for your work!

faelenor commented 9 years ago

Oh, I just realized that the pub/sub feature of Redis is not tied to a database! It means that the database config I added is useless and should be removed. The support for authentication is still useful though.

chiwanpark commented 9 years ago

@faelenor Okay. I'll remove database configuration.