chiwanpark / flume-ng-redis

Redis extension for Flume NG
26 stars 20 forks source link

Add pluggable handlers #9

Closed faelenor closed 9 years ago

faelenor commented 9 years ago

I added a pluggable handler system for the source. I'm not sure if you're interested to merge it, but you can have a look. It's based on the Flume HTTP Source.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-18.86%) to 64.14% when pulling d761130849c2d106b4365d03df43c72df85417fd on faelenor:master into 15b166b58a2ce22df281ebfe2f5726a47bdeb5d9 on chiwanpark:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-18.86%) to 64.14% when pulling d761130849c2d106b4365d03df43c72df85417fd on faelenor:master into 15b166b58a2ce22df281ebfe2f5726a47bdeb5d9 on chiwanpark:master.

chiwanpark commented 9 years ago

Wow! Great work! But I have a problem merging this pull request. Because of order of commit, there is a duplicated commit d761130 in your pull request. I think that you didn't update your repository as much as upstream. (chiwanpark/flume-ng-redis)

Could you rebase your pull request to remove duplicated commit?

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-22.02%) to 60.98% when pulling 9b433023514227a67334dd73a5e873b27900473d on faelenor:master into 15b166b58a2ce22df281ebfe2f5726a47bdeb5d9 on chiwanpark:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-22.02%) to 60.98% when pulling 9b433023514227a67334dd73a5e873b27900473d on faelenor:master into 15b166b58a2ce22df281ebfe2f5726a47bdeb5d9 on chiwanpark:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-22.02%) to 60.98% when pulling 6b290aa0ef70204689de1f99f2a304099a820779 on faelenor:master into a27dc946fd3ecb8d8a43cc0ebb456fd4462f5da3 on chiwanpark:master.