luaneko
commented
3 years ago I believe we can also make use of the global state variable which is the Config object at the utils/configs.ts file.
To be precise it's not a global state variable, it's passed on via a React context :) I don't think there's any global state in this codebase.
We can add a new subtype inside the Config object, let's say weeklyBosses, and it will be an array which stores the strings Dvalin, Andrius, and Childe. The strings there will be used in the Home/DomainView/index.tsx file to render the stored 'bosses'.
Instead of storing boss names, we should store the names of characters which require such bosses, so the field would be named like charactersWeekly.
In the MaterialDisplay component, we can pass a new prop, let's say isWeekly to the Toggle component. If isWeekly is true, then we will render the checkboxes for the bosses. If isWeekly is false, then we will render the checkboxes for Common Ascension Materials.
We can simplify that by simply changing this line
const [list, setList] = useConfig("characters");like this
const [list, setList] = useConfig(isWeekly ? "charactersWeekly" : "characters");Then there would be no need for a new component and duplicated code. The isWeekly prop would be passed to MaterialDisplay which just passes it onto Toggle.
lauslim12
Problem
Issue number #36 (lack of weekly boss materials).
What I Added
node genassetstalentMaterialWeeklycolumn, as requested)Results
With Diluc:
With Keqing:
With Ayaka (should not be displayed because she does not have any weeklies):
With Ganyu (have not added the Golden House yet, will do in a separate PR after this is done):
Bugs
When clicking on the
Show on Schedulebutton, the talent level-up material will also get clicked 😅. I suggest to pass a different prop or create a new checkbox whose purpose is to add the weekly boss to the list of tasks to be done.EDIT: After reading the codebase further, I believe we can also make use of the global state variable which is the
Configobject at theutils/configs.tsfile. We can add a new subtype inside theConfigobject, let's sayweeklyBosses, and it will be an array which stores the stringsDvalin,Andrius, andChilde. The strings there will be used in theHome/DomainView/index.tsxfile to render the stored 'bosses'.Then, in order to trigger the storage, the easiest way is that we have to make a new component, let's say
ToggleWeekly.tsx. This component will be exactly the same asToggle.tsx, with the difference only being that theuseConfigthat we use will be theweeklyBosses.Well, actually we do not need to create a new component, just an
ifstatement in theToggle.tsxto differentiate it from the talent materials will suffice. In theMaterialDisplaycomponent, we can pass a new prop, let's sayisWeeklyto theTogglecomponent. IfisWeeklyistrue, then we will render the checkboxes for the bosses. IfisWeeklyisfalse, then we will render the checkboxes forCommon Ascension Materials.Still, in this case, making a new component is probably easier rather than passing props around.
Closing
Thank you!
Resolves #36