search

chiyadev / genshin-schedule

🕑 Genshin farming scheduler
https://genshin.chiya.dev
MIT License
72 stars 17 forks source link

Add Portable Waypoint #41

Closed lauslim12 closed 3 years ago

lauslim12 commented 3 years ago

Problem

Issue number #38 (portable waypoint as an icon)

Fix

I added the portable waypoint icon with the reset timer being 7 days (168 hours). I placed it at the start of the list of icons for convenience.

Results

image

image

image

Closing

Before I forget, what do you think about these blue borders that appears after we clicked on something?

image

image

I know Chakra UI components are supposed to conform to WAI-ARIA standards (for keyboard accessibility), but I know the workaround to make it so mouse users wouldn't have to see the blue borders. Keyboard users will still see the blue borders (for accessibility).

I believe it might be a good small addition that will affect the user experience a lot.

Thank you!

Resolves #38

luaneko commented 3 years ago

Personally I feel like portable waypoint belongs between the "sigils" and "currency" categories.

The icons are sorted in the order of significance, but significance is a subjective quality. Is there a reason portable waypoint has to be at the top of the list? I just want to hear your opinion.

Before I forget, what do you think about these blue borders that appears after we clicked on something?

I don't think it matters much to be honest. Accessibility is not a concern for this website because visually impaired people probably don't play Genshin anyway.

lauslim12 commented 3 years ago

The icons are sorted in the order of significance, but significance is a subjective quality. Is there a reason portable waypoint has to be at the top of the list? I just want to hear your opinion.

My opinion (subjective of course) is that if we place a portable waypoint at the top is that it makes searching for it much easier without having to use the search functionality. I imagine that it would be a good user experience if we could update our portable waypoint location as easy as possible. An example use case for this would be if one updates the location of their portable waypoint every week. We just need to click on the first icon and update the location of our portable waypoint.

Of course, this is subjective and if you want the icon located between 'sigils' and 'currency' categories, then I will change it, don't worry 😅.

I don't think it matters much to be honest. Accessibility is not a concern for this website because visually impaired people probably don't play Genshin anyway.

Alright, understandable! I thought about that to improve the UX for a bit (make it slightly cooler without the blue borders haha!), but if you say it doesn't matter much, then okay, no need to change it!

luaneko commented 3 years ago

Fair reasoning