search

chiyadev / genshin-schedule

🕑 Genshin farming scheduler
https://genshin.chiya.dev
MIT License
72 stars 17 forks source link

Add resin mode switcher to settings #50

Closed Primajin closed 3 years ago

Primajin commented 3 years ago

Closes #47

Off

off off-2

On

on on-2

luaneko commented 3 years ago

I didn't fully understand what the issue was saying until you submitted this PR 🤦

It's actually already possible to switch between the estimation modes by clicking on the resin icon left to the calculator, but a setting like this would make it more explicit.

I don't think a switch is the right component though; in terms of UX, I think a select with "By time" and "By value" would be more appropriate. What do you think?

Primajin commented 3 years ago

Yes that sounds better, will change that!

Primajin commented 3 years ago

How about this: image

luaneko commented 3 years ago

Ahh thanks, I couldn't find a configured linter - shall we add eslint / prettier or something alike in the future?

If you are using vscode, I think it should automatically detect Prettier? It's already installed and configured for this repository.

Primajin commented 3 years ago

Ah I'm on Webstorm, thanks maybe I forgot to turn it on correctly