search

chiyadev / genshin-schedule

šŸ•‘ Genshin farming scheduler
https://genshin.chiya.dev
MIT License
72 stars 17 forks source link

Implement Bahasa Indonesia Translation #69

Closed lauslim12 closed 3 years ago

lauslim12 commented 3 years ago

Hi!

I noticed that you have added the i18n feature for the web application. I just want to add Bahasa Indonesia to the website. There are several (or many? I don't know the exact amount, I never researched šŸ˜…) people in my country who use your website for their scheduling needs.

The Bahasa Indonesia that I use is not really 'formal' to prevent 'awkwardness' (several general terms in English are still kept because they are easier and its less awkward to explain), while still using several in-game terms so the language does not confuse anyone.

Question

I also noticed several things that you may have forgotten to add i18n to. An example is this.

Capture

Is the English part intentional in the Discord guidelines? Because I didn't see anything in the language translation file regarding that.

Another one is this. You forgot to add the 'Features' heading to the i18n.

Capture1

Is this intentional?

Suggestion

I have a suggestion. Would it be better if we also place the language switcher in the homepage / main page of the website (the one in my second screenshot)? That way, people can instantly change the website language to the one of their wishes. Right now, I don't think it is possible to return back to that specific page with the changed language, unless if we do a clever hack (disabling getServerSideProps in index.tsx).

Thanks!

luaneko commented 3 years ago

Sorry for the late reply;; I was a little busy with other things.

Is the English part intentional in the Discord guidelines? Because I didn't see anything in the language translation file regarding that.

and

Another one is this. You forgot to add the 'Features' heading to the i18n.

These have been addressed in #64.

Would it be better if we also place the language switcher in the homepage / main page of the website (the one in my second screenshot)?

This has been suggested by others as well and it's on my (ever-growing) todo list. It should come as a separate PR.

Current plan is to read the Accept-Language header of requests and use it as the default, but I don't know if this approach is feasible yet. Needs more investigation.

luaneko commented 3 years ago

Following #64 I decided to move the translation workflow to an external platform Weblate to allow continuous translation and make the process more accessible to people.

Unfortunately that means I can't merge this PR. Instead, I went ahead and created an Indonesian translation component and manually entered your translations on the website. I hope this is fine with you.

There are still a few missing translations for parts of the UI (especially the notifications page you mentioned). It would be great if you could address those too. Thank you! :)

lauslim12 commented 3 years ago

No worries at all!

I will update the Indonesian translation as soon as possible.

Thanks!