chiyadev / genshin-schedule

🕑 Genshin farming scheduler
https://genshin.chiya.dev
MIT License
72 stars 17 forks source link

Show realm currency steps and sync with the resin estimator #70

Closed Primajin closed 3 years ago

Primajin commented 3 years ago

The resin calculator has the great way of switching between time and value based estimation:

While the recently added realm currency currently only shows one value:

I would wish for something similar in terms of estimation - at best synced with the setting of resin:

(mockup)

I'll try to take a stab at it.

Primajin commented 3 years ago

:construction: WORK IN PROGRESS :construction:

Too much information?

tmi

responsive

Primajin commented 3 years ago

What do you think @phosphene47? Would this be helpful? How can we make that much info a bit more accessible? Maybe we only render the first 3 and the last three and then only show the ones in between when a user explicitly clicks on show more?

luaneko commented 3 years ago

What do you think @phosphene47? Would this be helpful? How can we make that much info a bit more accessible?

I definitely think it's way too much information. How about exponentials steps of 2 * 100? i.e. 100, 200, 400, 800, 1600, 2400 (max at trust 10).

Primajin commented 3 years ago

Yeah the reasoning behind the step I chose was that all the blueprints you want to buy are either 60, 180, 240 so then you know "ohh in X hours I can finally get that blueprint" - how about we let the user choose what steps they'd like? I'll whip something up after breakfast 🙂

Primajin commented 3 years ago

For the other estimator we can then also allow for granulated estimation by X hours

Primajin commented 3 years ago

This looks quite reasonable, what do you think?

luaneko commented 3 years ago

960 in 36 hours 55 minutes 1920 in 73 hours 50 minutes

I think these are better formatted as:

960 in 1 day 12 hours 55 minutes 1920 in 3 days 1 hour 50 minutes

Also, it's missing the last and most important step which is the estimated time until completion! (2400 in this case; trust rank 10.)

Primajin commented 3 years ago

OK here is an updated version:

timevalue

I thought it makes sense to show the date if it is more than 24h in the future, what do you think? Also since realm currency goes in hourly steps and over a longer period, I guess minutes are not needed, right?

I have still a limitation that I couldn't yet wrap my head around - currently the steps are kind of hardcoded multiples of 60 (because blueprint price) starting from 0 - but I guess it would be better to start them from the current value? Otherwise when you have already accumulated some it will show less steps and at some point omits them completely 🤔

limitation
luaneko commented 3 years ago

I thought it makes sense to show the date if it is more than 24h in the future, what do you think?

Looks good!

Also since realm currency goes in hourly steps and over a longer period, I guess minutes are not needed, right?

Yes, I think including minutes would be an unnecessary detail.

I have still a limitation that I couldn't yet wrap my head around - currently the steps are kind of hardcoded multiples of 60 (because blueprint price) starting from 0 - but I guess it would be better to start them from the current value?

I think keeping it simple and using multiples of 60 is good. It's also consistent with the behavior of resin estimates.

Primajin commented 3 years ago

Ohh wait is it 60 or 80?

Primajin commented 3 years ago

OK made it steps of 80 - I double checked that that's the correct price.

Removed minutes from time based estimation steps but kept for value based since the next step of 80 could just be around the corner

If that limitation doesn't bother you I'd say this is up for review now 👍🏻