chiyadev / genshin-schedule

🕑 Genshin farming scheduler
https://genshin.chiya.dev
MIT License
72 stars 17 forks source link

+60 resin button for Transient/Fragile Resin #84

Closed ImmortalZypther closed 2 years ago

ImmortalZypther commented 3 years ago

Since Transient Resin is easier to get than Fragile Resin, a +60 resin button would be useful to keep the resin synched after you're done setting it.

An alternative would be a box that lets you input a custom amount of resin to add or remove, removing the need for additional buttons in the future.

luaneko commented 3 years ago

Since Transient Resin is easier to get than Fragile Resin, a +60 resin button would be useful to keep the resin synched after you're done setting it.

I'm not sure if we want to introduce any more buttons to the resin calculator. Four is the absolute maximum we can afford and it already looks clunky.

image

An alternative would be a box that lets you input a custom amount of resin to add or remove, removing the need for additional buttons in the future.

Resin calculator already allows manual input by clicking on the resin number.

image

ImmortalZypther commented 3 years ago

I knew about that form of manual input, but that also changes the timing of your resin recharge.

The reason the buttons are more useful is them keeping your resin in sync if you've timed it with your actual resin recharging.

luaneko commented 3 years ago

I agree that adding a method to manually input resin count (and by extension a +/-any number button) without losing timing accuracy would be nice, but I don't think adding more buttons is a good solution in terms of UI and UX.

I'm not sure how to approach this; open to ideas.

ImmortalZypther commented 3 years ago

I personally favor the third idea because it only adds a single button and skips any potential math if you do multiple resin changes in a short amount of time (using fragile, doing a couple bosses, doing a leyline, etc.). All you need to do once it's locked is input the resin you're at by the end, no pressing buttons required.

luaneko commented 2 years ago

I merged a PR that allows creating custom resin buttons. I think it's a good compromise between being able to quickly add/subtract a custom amount, and making an input in the calculator that allows add/subtract without losing timing accuracy.

It does bother me that too many buttons can clutter the UI (especially on mobile screens), but that would be on the user adding too many buttons by choice. The default is still four subtraction buttons -60, -40, -30, -20.