Fix predict.flexsurvreg to work with rewrite of summary.flexsurvreg

chjackson / flexsurv

The flexsurv R package for flexible parametric survival and multi-state modelling

http://chjackson.github.io/flexsurv/

53 stars 28 forks source link

Fix predict.flexsurvreg to work with rewrite of summary.flexsurvreg #118

Closed mattwarkentin closed 2 years ago

mattwarkentin commented 2 years ago

Fixes #117

Possibly relevant to: https://github.com/tidymodels/censored/issues/152

Edit: Upon reflection, I see some areas to improve and clean up this PR that I will address when I get into the office tomorrow. So please feel free to review, but I intend to make some changes tomorrow morning,

mattwarkentin commented 2 years ago

Okay, @chjackson, I think this PR is ready for you to review.

Of note, I was unable to write tests for checking standard errors (or confidence intervals) because they are based on simulation and are not expected to be identical between independent calls to summary.flexsurvreg(). I tried setting seeds but was unsuccessful. Just thought I'd share.

chjackson commented 2 years ago

Thanks and sorry for the hassle!