chjackson / flexsurv

The flexsurv R package for flexible parametric survival and multi-state modelling
http://chjackson.github.io/flexsurv/
54 stars 28 forks source link

activate bash strict mode for CI #86

Closed kkmann closed 2 years ago

kkmann commented 3 years ago

I think the current setup does not honestly report the results of R CMD CHECK because you call devtools::test afterwards and Travis does not use bash strict mode by default (i.e. currently 'checks passed' only means that the tests run through, but not the full check).

See also https://github.com/travis-ci/travis-ci/issues/1066

I think a line - set -e would be needed but that depends a bit on the intended behaviour.

kkmann commented 3 years ago

alternatively, just removing the explicit call to ´devtools::test´ would also do the trick. my understanding is that ´R CMD check´ runs the tests anyhow

https://github.com/chjackson/flexsurv-dev/blob/722389158e87ec02ccc618cea249d8634db0067d/.travis.yml#L12

kkmann commented 3 years ago

currently, some of the multicore tests seem to fail. Note that - Rscript -e 'devtools::test()' will not lead to a failed CI build even if there are tests failing, is that intended?

kkmann commented 3 years ago

the relevant section in the docs is here: https://docs.travis-ci.com/user/languages/r/#customizing-the-travis-build-steps

chjackson commented 2 years ago

Now using github actions instead of travis