search

chjj / bns

Recursive DNS server and resolver for node.js
Other
65 stars 25 forks source link

Doc example doesn't seem to work #1

Open zbjornson opened 6 years ago

zbjornson commented 6 years ago

It looks like the readme examples are out of date.

In the Base Server example, dns.Server is undefined (it's not exported from require("bns")).

If I change it to bns.DNSServer, server.on("query") is never invoked and an assertion error is emitted from server.on("error").

If I change it to bns.AuthServer, server.on("query") is invoked, but it looks like you shouldn't call res.send() ("res.send is not a function" is emitted). An assertion error happens in this case also.

If I change it to bns.StubServer, ditto, except Error: No servers available is emitted instead of the assertion failure.

Since you're apparently not supposed to call res.send(), does that mean it's not possible to have an async response?

(bns@0.3.0)

jafri commented 5 years ago

@chjj same issue here, bns.Server should be bns.DNSServer in docs and server.on("query") is never invoked following the example code...cannot get this library working.