chjj / pty.js

Bindings to forkpty(3) for node.js.
MIT License
857 stars 211 forks source link

replace node-waf bindings to node-gyp #189

Open sr229 opened 7 years ago

sr229 commented 7 years ago

it seems according to this Stack Overflow Discussion, node-waf is replaced with node-gyp so you might wanna change your bindings to use this.

abalter commented 7 years ago

Same issue. Cloned and then...

(uiserver):u89924123:~/pty.js$ make
make[1]: Entering directory '/homepages/32/d690510543/htdocs/pty.js'
node-waf configure build
Traceback (most recent call last):
  File "/kunden/homepages/32/d690510543/htdocs/conda/bin/node-waf", line 14, in <module>
    import Scripting
  File "/homepages/32/d690510543/htdocs/conda/bin/../lib/node/wafadmin/Scripting.py", line 146
    except Utils.WafError, e:
                         ^
SyntaxError: invalid syntax
Makefile:5: recipe for target 'waf' failed
make[1]: *** [waf] Error 1
make[1]: Leaving directory '/homepages/32/d690510543/htdocs/pty.js'
Makefile:2: recipe for target 'all' failed
make: *** [all] Error 2
DanielRuf commented 6 years ago

I guess you all pull my https://www.npmjs.com/package/node-waf

sr229 commented 6 years ago

@DanielRuf Unfortunately, I don't think this repo has been updating properly its node-waf version