search

chkiefer / lavacreg

lavacreg (Latent Variable Count Regression Models)) is an R package to estimate multigroup structural equation models with count regressions (Poisson or negative binomial).
https://chkiefer.github.io/lavacreg/
3 stars 2 forks source link

Define STRICT_R_HEADERS, change PI to M_PI #1

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Dear Christoph,

Your CRAN package lavacreg uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here, we prefixed two #include with STRICT_R_HEADERS. The actual change that is needed is the change from PI to M_PI in two files.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

eddelbuettel commented 3 years ago

Thank you for the prompt merge!