search

chkuendig / hass-amphiro-ble

🚿 Amphiro Digital Hand Shower component for Home Assistant
https://christian.kuendig.info/posts/2023-01-hass-amphiro/
MIT License
8 stars 2 forks source link

Fixup for energy measurement (wrong type) and 2024.6 compatibility #9

Closed bipsendk closed 3 months ago

bipsendk commented 3 months ago

Class for energy should not be power (it is not electricity - it is heating) class AmphiroBluetoothSensorEntity updated in order to work with HomeAssistant build 2024.6

chkuendig commented 3 months ago

Thanks for submitting this, I'll quickly test it myself before merging, but generally this looks good!

bipsendk commented 3 months ago

Gets these errors during pull:

validate-hacs

failed: The repository has no valid topics (More info: https://hacs.xyz/docs/publish/include#check-repository ) [validate-hacs](https://github.com/bipsendk/hass-amphiro-ble/actions/runs/9552659183/job/26330373017#step:4:18) 1/8 checks failed [validate-hacs](https://github.com/bipsendk/hass-amphiro-ble/actions/runs/9552659183/job/26330373017) Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
chkuendig commented 3 months ago

Looks good. I made some minor adjustments to reflect this more in line with changes made to upstream (home-assistant/core@da3509780366876a93b8d5171e89a9ad8f243614 and home-assistant/core@4f4389ba850190a19473b593015c89013198aa9e ).

Gets these errors during pull: [...]

You can ignore these. They only fail on your fork as it's missing some settings for a potentitial HACS integration (and the node one is just a warning). On this repo they pass.