Closed lassepe closed 8 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
72d8307
) 94.33% compared to head (2c34f9e
) 94.14%.
Files | Patch % | Lines |
---|---|---|
src/C_API.jl | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can't we tell from the fact that the status is MCP_UserInterrupt
? Why does an error need to be thrown?
Your for-loop should handle the interrupted status case instead.
Yeah, if you don't want it here, can also do it downstream in my own lib. Feel free to close this in that case
Just to check before closing: does PATH correctly terminate with MCP_UserInterrupt
on a CTRL+C?
Yes, it does.
Currently, when running PATH in a for-loop, one cannot really interrupt the program reliably. The reason for this is that the
ctrl+c
will often just be caught by PATH (in C) but the interrupt is never forwarded to Julia. This PR throws an interrupt error when the status of the C call is MCP_UserInterrupt.