chkwon / PATHSolver.jl

provides a Julia wrapper for the PATH Solver for solving mixed complementarity problems
http://pages.cs.wisc.edu/%7Eferris/path.html
MIT License
50 stars 15 forks source link

Replace PATHSolver with odow/PATH.jl #44

Closed odow closed 3 years ago

odow commented 3 years ago

I started to register PATH.jl as a new package. However, it was pointed out that "PATH" is a pretty common name to add the the registry, and PATHSolver already exists, so we should just make a complete overhaul of PATHSolver.

Closing all open issues as irrelevant. People can re-open if they encounter bugs in the new package. Closes #4 Closes #15 Closes #18 Closes #38

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (540c5ac) into master (525fa11) will decrease coverage by 2.21%. The diff coverage is 94.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   96.84%   94.62%   -2.22%     
==========================================
  Files           1        3       +2     
  Lines          95      242     +147     
==========================================
+ Hits           92      229     +137     
- Misses          3       13      +10     
Impacted Files Coverage Δ
src/PATHSolver.jl 100.00% <ø> (+3.15%) :arrow_up:
src/C_API.jl 92.95% <92.95%> (ø)
src/MOI_wrapper.jl 96.96% <96.96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 525fa11...7119a05. Read the comment docs.

odow commented 3 years ago

@chkwon ready to merge this when you are, or you could add me as a collaborator?

chkwon commented 3 years ago

@odow Do you think transferring the ownership to you would help you manage? I'd do it if you like.

odow commented 3 years ago

Happy to leave it here for now. We can revisit if it becomes a problem. Another option is to add it to jump-dev if we want to add some complementarity examples.