chkwon / PATHSolver.jl

provides a Julia wrapper for the PATH Solver for solving mixed complementarity problems
http://pages.cs.wisc.edu/%7Eferris/path.html
MIT License
50 stars 15 forks source link

variable_name, constraint_name in solve_mcp #48

Closed chkwon closed 3 years ago

chkwon commented 3 years ago

Supporting variable_name and constraint_name for output in PATH.

function solve_mcp(
    F::Function,
    J::Function,
    lb::Vector{Cdouble},
    ub::Vector{Cdouble},
    z::Vector{Cdouble};
    nnz::Int = length(lb)^2,
    variable_name::Vector{String}=String[],
    constraint_name::Vector{String}=String[],
    silent::Bool = false,
    kwargs...
)

Not sure how this can be handled in MOI.

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (f048179) into master (6d8c668) will decrease coverage by 2.57%. The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   94.65%   92.07%   -2.58%     
==========================================
  Files           3        3              
  Lines         243      265      +22     
==========================================
+ Hits          230      244      +14     
- Misses         13       21       +8     
Impacted Files Coverage Δ
src/C_API.jl 89.09% <65.21%> (-3.92%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d8c668...4d38863. Read the comment docs.

odow commented 3 years ago

At the very least, we didn't crash the binaries, so it seems okay.