chkwon / PATHSolver.jl

provides a Julia wrapper for the PATH Solver for solving mixed complementarity problems
http://pages.cs.wisc.edu/%7Eferris/path.html
MIT License
50 stars 15 forks source link

Fix models with no VariablePrimalStart set #81

Closed odow closed 1 year ago

odow commented 1 year ago

Closes #80

It's a double whammy. There was a bug if no start values are given (we'd pick Inf), but we also told PATH the problem was linear and that it could evaluate the Jacobian once. But evaluating the Jacobian at Inf caused it to terminate. I guess before it was trying to check another point because it didn't know that the Jacobian was constant.

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.02% // Head: 92.04% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (6d11949) compared to base (b55bc4b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81 +/- ## ========================================== + Coverage 92.02% 92.04% +0.02% ========================================== Files 3 3 Lines 376 377 +1 ========================================== + Hits 346 347 +1 Misses 30 30 ``` | [Impacted Files](https://codecov.io/gh/chkwon/PATHSolver.jl/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Changhyun+Kwon) | Coverage Δ | | |---|---|---| | [src/MOI\_wrapper.jl](https://codecov.io/gh/chkwon/PATHSolver.jl/pull/81?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Changhyun+Kwon#diff-c3JjL01PSV93cmFwcGVyLmps) | `96.80% <100.00%> (+0.02%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Changhyun+Kwon). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Changhyun+Kwon)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.