search

chladog / payload-webp

payloadcms/payload plugin for automatic image conversion to webp format.
https://www.npmjs.com/package/payload-webp
GNU General Public License v3.0
44 stars 5 forks source link

Please update dependencies #8

Closed christian-reichart closed 1 year ago

christian-reichart commented 1 year ago

Hello, great tool! I wanted to try it but on install I get a lot of deprecation warnings, I think this has mainly to do with the Payload Version.

As I don't really know what to test for it's hard for me to create a PR and ensure that everything is still working as expected.

Thanks & Cheers

Update: I think the missing peer dependencies is a general problem of Payload. But npm tells me that since Version 1.0.1 this module depends on a vulnerable version of sharp.

With that, it would be maybe a good idea to update the dependency on Payload to some version >1.

chladog commented 1 year ago

hello @christian-reichart you are right, the versions are sometimes behind. I tried to use newer version than Payload used, but that was failing (I guess it's not possible to combine multiple version of sharp binaries in single project). The versions have been updated in this plugin, to handle version mismatch you can set wanted sharp version in resolutions field in package.json

  "resolutions": {
    "sharp": "latest"
  }