search

chleggett / homebrew-gr-osmosdr

3 stars 7 forks source link

Update formula to resolve Brew's complaints. #9

Closed chtzvt closed 6 years ago

chtzvt commented 6 years ago

I've resolved the following complaints from Brew about this formula: 

Warning: Calling 'depends_on :python' is deprecated!
Use 'depends_on "python"' instead.
/usr/local/Homebrew/Library/Taps/chleggett/homebrew-gr-osmosdr/gr-osmosdr.rb:9:in `<class:GrOsmosdr>'
Please report this to the chleggett/gr-osmosdr tap!

Warning: Calling 'depends_on ... => :python' is deprecated!
There is no replacement.
/usr/local/Homebrew/Library/Taps/chleggett/homebrew-gr-osmosdr/gr-osmosdr.rb:11:in `<class:GrOsmosdr>'
Please report this to the chleggett/gr-osmosdr tap!

Aside from the minor syntax adjustment on the python dependency, it seems that Brew no longer wishes to manage dependencies on language modules (more info here).

As a result, I've removed the dependency on Cheetah, and instead updated README.md to reflect this dependency (so that the user knows to install Cheetah beforehand, via pip).

Thanks again for the great tap!

chleggett commented 6 years ago

Hey @ctrezevant thanks for the changes.

This formula isn't abandoned exactly, but I haven't been using the software as much as I once did so YMMV on using it.

chtzvt commented 6 years ago

No worries. It's been a while since I've last used this tap, myself, but I figured I'd give back a bit since it had been so useful to me in the past :)

Thanks again!