chloeelim / ped

0 stars 0 forks source link

Invalid address inputs for `add` #8

Open chloeelim opened 2 years ago

chloeelim commented 2 years ago

Description

Currently, there is no restriction on the address inputs (all strings are valid). This means that an address like a/Commonwealth c/loseblock123 should technically be allowed by TA Assist (since addresses like a/Commonwealth b/loseblock123 are allowed), and there is no restriction on the address specified in the UG or command parser.

However, quite clearly, there would be issues parsing an addressa/Commonwealth c/loseblock123 because the command is ambiguous, and parser would pick c/loseblock123 as a class parameter rather than being part of the address.

Since most addresses generally do not have a "/" in them, perhaps it would be better to impose character constraints on addresses, just like how other parameters do not allow slashes in them?